-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noetic support #39
Noetic support #39
Conversation
Resolve "Missing dependencies" Closes #1 See merge request inigo.moreno/executive_smach_visualization!1
I have been looking into the deps and I believe only these two are missing from the rosdeps:
|
Did you request them to be added there? |
Xdot got merged. Can somebody trigger CI again? |
Seems like kinetic should be removed from CI |
In addition, from here I needed the following: sudo apt install libxt-dev libgirepository1.0-dev
pip install pycairo PyGObject |
Since the melodic branch has changes inspired by this PR to fix noetic, can this PR now be closed? Because it has major conflicts and it suggests that noetic is not supported 🙂 |
Agreeing with @Timple to close this PR. |
I have a working version of smach_viewer in noetic!
I have refactored a lot of the code (especially on the xdot library), so it might be a bit difficult to read through the changes.
The rosdeps are not correctly defined, as not all of them are available (I will need to do a PR of ros_distro). To run the repo you need to install the following manually (not sure which are necessary):
Also, I can't create a new branch on the repo, so I set the base of the fork to melodic-devel, but Ideally, a new noetic-devel branch should be created and the base of this fork changed.
Fixes #29
Fixes #34
Fixes #36