Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noetic support #39

Closed

Conversation

InigoMoreno
Copy link

@InigoMoreno InigoMoreno commented Jan 13, 2022

I have a working version of smach_viewer in noetic!

I have refactored a lot of the code (especially on the xdot library), so it might be a bit difficult to read through the changes.

The rosdeps are not correctly defined, as not all of them are available (I will need to do a PR of ros_distro). To run the repo you need to install the following manually (not sure which are necessary):

 apt install gir1.2-gtk-3.0 python3-gi python3-gi-cairo python3-numpy graphviz
 python3 -m pip install xdot wxpython

Also, I can't create a new branch on the repo, so I set the base of the fork to melodic-devel, but Ideally, a new noetic-devel branch should be created and the base of this fork changed.

Fixes #29
Fixes #34
Fixes #36

@InigoMoreno
Copy link
Author

InigoMoreno commented Jan 13, 2022

I have been looking into the deps and I believe only these two are missing from the rosdeps:

apt install python3-gi-cairo
 python3 -m pip install xdot

@Timple
Copy link

Timple commented Feb 1, 2022

I have been looking into the deps and I believe only these two are missing from the rosdeps:

apt install python3-gi-cairo
 python3 -m pip install xdot

Did you request them to be added there?

smach_viewer/package.xml Outdated Show resolved Hide resolved
@Timple
Copy link

Timple commented Feb 9, 2022

Xdot got merged. Can somebody trigger CI again?

@Timple
Copy link

Timple commented May 16, 2022

Seems like kinetic should be removed from CI

@vineet131
Copy link

I have a working version of smach_viewer in noetic!

I have refactored a lot of the code (especially on the xdot library), so it might be a bit difficult to read through the changes.

The rosdeps are not correctly defined, as not all of them are available (I will need to do a PR of ros_distro). To run the repo you need to install the following manually (not sure which are necessary):

 apt install gir1.2-gtk-3.0 python3-gi python3-gi-cairo python3-numpy graphviz
 python3 -m pip install xdot wxpython

Also, I can't create a new branch on the repo, so I set the base of the fork to melodic-devel, but Ideally, a new noetic-devel branch should be created and the base of this fork changed.

Fixes #29
Fixes #34
Fixes #36

In addition, from here I needed the following:

sudo apt install libxt-dev libgirepository1.0-dev

pip install pycairo PyGObject

@martinerk0 martinerk0 mentioned this pull request Jun 26, 2022
k-okada added a commit to k-okada/executive_smach_visualization that referenced this pull request Jul 20, 2022
@k-okada k-okada mentioned this pull request Jul 20, 2022
k-okada added a commit to k-okada/executive_smach_visualization that referenced this pull request Jul 20, 2022
k-okada added a commit that referenced this pull request Jul 31, 2022
@Timple
Copy link

Timple commented Feb 23, 2023

Since the melodic branch has changes inspired by this PR to fix noetic, can this PR now be closed?

Because it has major conflicts and it suggests that noetic is not supported 🙂

@MatthijsBurgh
Copy link
Contributor

Agreeing with @Timple to close this PR.

@k-okada k-okada closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants