Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup new structure #246

Merged
merged 14 commits into from
Mar 3, 2023
Merged

Cleanup new structure #246

merged 14 commits into from
Mar 3, 2023

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Feb 23, 2023 •
edited
Loading

This PR closes some of the open tasks of #232

@christophfroehlich christophfroehlich marked this pull request as ready for review February 23, 2023 22:57
@christophfroehlich
Copy link
Contributor Author

I hope I got the CMakeLists.txt structure right, at least it compiles and the examples work.

christophfroehlich
christophfroehlich commented Feb 25, 2023
View reviewed changes
doc/index.rst
.. _ros2_control_demos:

#################
Demos
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which infos should we move from README.md to this rst file? All except build instructions and build?

If someone starts from control.ros.org with installed debian packages, the Getting started section is maybe not necessary in the documentation but only in the readme if the repo is checked out?

What about the figures in the doc folder, they are at least not up-to-date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a suggestion, feel free to comment.
I had to rename the README.rst to doc/userdoc.rst, because it would be excluded otherwise. Is there a reason for that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think rst would be upset about the too many ###?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sphinx did not complain. I think the type of character does not matter.

destogl
destogl reviewed Mar 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
destogl
destogl approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply great!

@destogl destogl merged commit 3de119c into ros-controls:new-structure-of-master Mar 3, 2023
@christophfroehlich christophfroehlich deleted the cleanup branch March 5, 2023 13:53
destogl pushed a commit that referenced this pull request Mar 8, 2023
@christophfroehlich @destogl
Cleanup new demos structure (#246)
2d17124
@christophfroehlich christophfroehlich mentioned this pull request Apr 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

@bmagyar bmagyar Awaiting requested review from bmagyar

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@livanov93 livanov93 Awaiting requested review from livanov93

@mhubii mhubii Awaiting requested review from mhubii

@rosterloh rosterloh Awaiting requested review from rosterloh

@Serafadam Serafadam Awaiting requested review from Serafadam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophfroehlich @destogl @bmagyar