Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a demo that uses transmissions #226
Create a demo that uses transmissions #226
Changes from 23 commits
ad7928c
75b7d9b
d92c9a0
305f287
e6a795e
e0b3c4d
73ed52e
d2f0048
1296d2c
6b30b7e
2d7fe62
311f60d
70d74d8
2f095cb
42cfca8
1cd2fb0
3c469c7
648fd09
9bd8017
8afa076
90fec58
af5d961
727b079
e769649
79b8272
0b00f35
4e98b53
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can further simplify this by deleting
use_gazebo
,use_fake_hardware
,mock_sensor_comands
hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this breaks the launch, since we use
rrbot_base.launch.py
as base. Maybe something that could be addressed in #231.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it? removing them here and lines 34+35 in rrbot_transmissions_system_position_only.urdf.xacro works for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the interest of merging this prior to the restructure, I'll open a general cleanup issue for xacro parameters
#240
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is quite confusing. Could you rename this variable please to clarify it's meaning/content?
What does it mean in the joint and in the actuator context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the sink of the Joint/Actuator handle that lives inside the transmission.
transmission_passthrough_
maybe?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you rename plus add this comment about the sink we are done ;)