Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix to strip the single quotes while using --controller-ros-args #1964

Conversation

saikishor
Copy link
Member

With the changes introduced in #1713. When updating the demos, if we encapsulate the args into single quotes, then it seems not to work.

We cannot leave single quotes in the launch description, as it complains for pre-commit. The proposed changes should handle both the cases

@saikishor saikishor force-pushed the fix/controller_node_options branch from cd4c352 to 72b519b Compare December 20, 2024 13:40
@saikishor saikishor changed the title Aadd fix to strip the single quotes while using --controller-ros-args Add fix to strip the single quotes while using --controller-ros-args Dec 20, 2024
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we need the single quotes in
"'--ros-args -r /bicycle_steering_controller/tf_odometry:=/tf'",
this

    robot_bicycle_controller_spawner = Node(
        package="controller_manager",
        executable="spawner",
        arguments=[
            'bicycle_steering_controller',
            '--param-file',
            robot_controllers,
            '--controller-ros-args',
            '--ros-args -r /bicycle_steering_controller/tf_odometry:=/tf',
        ],
    )

works as well as

    robot_bicycle_controller_spawner = Node(
        package="controller_manager",
        executable="spawner",
        arguments=[
            "bicycle_steering_controller",
            "--param-file",
            robot_controllers,
            "--controller-ros-args",
            "--ros-args -r /bicycle_steering_controller/tf_odometry:=/tf",
        ],
    )

without the changes of this PR.

@saikishor
Copy link
Member Author

@christophfroehlich You are totally right. It should be probably due to some local changes

@saikishor saikishor closed this Dec 20, 2024
@saikishor saikishor deleted the fix/controller_node_options branch December 20, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants