Moved TriggerType enum to dedicated file to avoid repetition in hardware component classes

[kumar-sanjeeev]

• Moved TriggerType enum to hardware_interface_trigger_type.hpp, to avoid repetition across hardware components classes.

Fixes: #1958

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (62b1908) to head (72ab66d).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
- Coverage   88.11%   88.10%   -0.01%     
==========================================
  Files         121      121              
  Lines       13174    13174              
  Branches     1187     1187              
==========================================
- Hits        11608    11607       -1     
  Misses       1132     1132              
- Partials      434      435       +1     

Flag	Coverage Δ
unittests	88.10% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../include/hardware_interface/actuator_interface.hpp	91.96% <ø> (ø)
...ce/include/hardware_interface/system_interface.hpp	81.81% <ø> (ø)

... and 1 file with indirect coverage changes

[saikishor]

May be we can add it to the hardware_interface_return_values.hpp along side

ros2_control/hardware_interface/include/hardware_interface/types/hardware_interface_return_values.hpp

Lines 20 to 29 in 612b30b

	namespace hardware_interface
	{
	enum class return_type : std::uint8_t
	{
	OK = 0,
	ERROR = 1,
	DEACTIVATE = 2,
	};
	} // namespace hardware_interface

instead of creating a new one.

WHat's your opinion on this @ros-controls/ros2-maintainers ?

[bmagyar]

Looks good to me. I'd simplify the file name to "trigger_type.hpp", the "hardware_interface" is already implied

[christophfroehlich]

Thanks!