-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Specify runner/container images and codecov for joint_limits #1504
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1504 +/- ##
===========================================
+ Coverage 62.67% 88.66% +25.98%
===========================================
Files 96 101 +5
Lines 11311 8238 -3073
Branches 8151 722 -7429
===========================================
+ Hits 7089 7304 +215
+ Misses 715 673 -42
+ Partials 3507 261 -3246
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine and the CI seems to be happy, as well (I assume the RHEL fail to be independent)
yes, and nothing new :( #1367 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
) * Specify runner/container images * Add joint_limits to coverage * Satisfy flake8 on noble (cherry picked from commit db00041) # Conflicts: # ros2controlcli/ros2controlcli/verb/load_controller.py
) * Specify runner/container images * Add joint_limits to coverage * Satisfy flake8 on noble (cherry picked from commit db00041)
) (#1520) * Specify runner/container images * Add joint_limits to coverage * Satisfy flake8 on noble (cherry picked from commit db00041) Co-authored-by: Christoph Fröhlich <[email protected]>
) (#1519) * Specify runner/container images * Add joint_limits to coverage * Satisfy flake8 on noble Co-authored-by: Christoph Fröhlich <[email protected]>
Necessary changes to make ros-controls/ros2_control_ci#53 work for noble.