Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR template #1000

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Conversation

christophfroehlich
Copy link
Contributor

Moves the PR template to a different folder, see ros-controls/ros2_control_demos#270 where this worked out.

@codecov-commenter
Copy link

Codecov Report

Merging #1000 (980c221) into master (925f5f3) will decrease coverage by 1.93%.
The diff coverage is 35.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
- Coverage   34.61%   32.69%   -1.93%     
==========================================
  Files          52       91      +39     
  Lines        2981     9551    +6570     
  Branches     1855     6432    +4577     
==========================================
+ Hits         1032     3123    +2091     
- Misses        310      704     +394     
- Partials     1639     5724    +4085     
Flag Coverage Δ
unittests 32.69% <35.61%> (-1.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.27% <ø> (-1.44%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 49.91% <ø> (-3.72%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.14% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp 32.44% <ø> (+4.25%) ⬆️
... and 68 more

... and 19 files with indirect coverage changes

@bmagyar
Copy link
Member

bmagyar commented Apr 28, 2023

I don't see any folder moving changes

@christophfroehlich
Copy link
Contributor Author

I don't see any folder moving changes

This is a bit hidden in the github web GUI, but see:

git diff HEAD~1
diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/pull_request_template.md
similarity index 92%
rename from .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
rename to .github/pull_request_template.md
index 87f389a..8e9178c 100644
--- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -1,11 +1 @@
-
----
-name: Pull request
-about: Create a pull request
-title: ''
-labels: ''
-assignees: ''
-
----
-

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I can see it now! Thanks!

@bmagyar bmagyar merged commit d0c7f33 into ros-controls:master Apr 29, 2023
1 check passed
@christophfroehlich christophfroehlich deleted the fix_pr_template branch March 23, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants