Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update pre-commit and remove ros-lint #187

Merged
merged 19 commits into from
Mar 4, 2024
Merged

[CI] Update pre-commit and remove ros-lint #187

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4b16e49
Test reusable workflow with composite action
christophfroehlich Feb 18, 2024
9913f96
Mv to ros2_control_ci
christophfroehlich Feb 18, 2024
eb94df8
Use wf from ros2_control_ci
christophfroehlich Feb 18, 2024
c1d2992
Activate lint job for all distros
christophfroehlich Feb 18, 2024
5768235
Test other workflows
christophfroehlich Feb 18, 2024
0a670d9
Test rhel workflow too
christophfroehlich Feb 18, 2024
24894d1
Update pre-commit config
christophfroehlich Feb 18, 2024
0a557c2
Remove unnecessary lint job
christophfroehlich Feb 18, 2024
9bec3db
Switch to master branch of ros2_control_ci
christophfroehlich Feb 18, 2024
a0b968b
Give new ros_distro input
christophfroehlich Feb 18, 2024
c6164c2
Update pre-commit config and fix codespell
christophfroehlich Feb 19, 2024
c6ec19a
Switch to master branch
christophfroehlich Feb 21, 2024
c00f378
Merge branch 'ros2-master' into ci_ros_lint
christophfroehlich Feb 21, 2024
39cf7d9
Update .github/workflows/ci-pre-commit.yml
christophfroehlich Feb 21, 2024
3d7b126
Add update-pre-commit wf
christophfroehlich Feb 23, 2024
6e08a84
Add apache license badge
christophfroehlich Feb 23, 2024
f567eca
Fix license badge
christophfroehlich Feb 23, 2024
b297e2c
Remove unnecessary link
christophfroehlich Feb 23, 2024
0c36078
Merge branch 'ros2-master' into ci_ros_lint
bmagyar Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-binary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:

jobs:
binary:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@ci_lint
christophfroehlich marked this conversation as resolved.
Show resolved Hide resolved
strategy:
fail-fast: false
matrix:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-source.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
source_build:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-ros-tooling-source-build.yml@master
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-ros-tooling-source-build.yml@ci_lint
christophfroehlich marked this conversation as resolved.
Show resolved Hide resolved
strategy:
fail-fast: false
matrix:
Expand Down
21 changes: 0 additions & 21 deletions .github/workflows/ci-format.yml
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions .github/workflows/ci-pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
name: Format
christophfroehlich marked this conversation as resolved.
Show resolved Hide resolved

on:
workflow_dispatch:
pull_request:

jobs:
pre-commit:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-pre-commit.yml@ci_format
christophfroehlich marked this conversation as resolved.
Show resolved Hide resolved
christophfroehlich marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion .github/workflows/debian-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:

jobs:
debian_source_build:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-debian-build.yml@master
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-debian-build.yml@ci_lint
christophfroehlich marked this conversation as resolved.
Show resolved Hide resolved
strategy:
fail-fast: false
matrix:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rhel-semi-binary-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:

jobs:
rhel_semi_binary_build:
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-rhel-binary-build.yml@master
uses: ros-controls/ros2_control_ci/.github/workflows/reusable-rhel-binary-build.yml@ci_lint
christophfroehlich marked this conversation as resolved.
Show resolved Hide resolved
strategy:
fail-fast: false
matrix:
Expand Down
59 changes: 0 additions & 59 deletions .github/workflows/ros-lint.yml
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,18 +76,15 @@ repos:
- id: ament_cppcheck
name: ament_cppcheck
description: Static code analysis of C/C++ files.
stages: [commit]
entry: ament_cppcheck
language: system
files: \.(h\+\+|h|hh|hxx|hpp|cuh|c|cc|cpp|cu|c\+\+|cxx|tpp|txx)$

# Maybe use https://github.com/cpplint/cpplint instead
- repo: local
hooks:
- id: ament_cpplint
name: ament_cpplint
description: Static code analysis of C/C++ files.
stages: [commit]
entry: ament_cpplint
language: system
files: \.(h\+\+|h|hh|hxx|hpp|cuh|c|cc|cpp|cu|c\+\+|cxx|tpp|txx)$
Expand All @@ -99,7 +96,6 @@ repos:
- id: ament_lint_cmake
name: ament_lint_cmake
description: Check format of CMakeLists.txt files.
stages: [commit]
entry: ament_lint_cmake
language: system
files: CMakeLists\.txt$
Expand All @@ -110,7 +106,6 @@ repos:
- id: ament_copyright
name: ament_copyright
description: Check if copyright notice is available in all files.
stages: [commit]
entry: ament_copyright
language: system

Expand Down
Loading