Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] fix source build #168

Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Dec 11, 2023

A minor fix for failing source build, follow up of #166, and some updates to README and codecov (see these tips)

@christophfroehlich christophfroehlich changed the title Ci/fix source build [CI] fix source build Dec 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

Merging #168 (0348099) into ros2-master (f669557) will increase coverage by 4.52%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff               @@
##           ros2-master     #168      +/-   ##
===============================================
+ Coverage        32.38%   36.91%   +4.52%     
===============================================
  Files               16       10       -6     
  Lines             1127      531     -596     
  Branches           595      167     -428     
===============================================
- Hits               365      196     -169     
+ Misses             227      220       -7     
+ Partials           535      115     -420     
Flag Coverage Δ
unittests 36.91% <ø> (+4.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@christophfroehlich christophfroehlich enabled auto-merge (squash) December 12, 2023 08:08
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bmagyar bmagyar disabled auto-merge December 12, 2023 11:34
@bmagyar bmagyar merged commit f3dee11 into ros-controls:ros2-master Dec 12, 2023
15 checks passed
@christophfroehlich christophfroehlich deleted the ci/fix_source_build branch December 12, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants