Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jazzy #293

Merged
merged 13 commits into from
May 13, 2024
Merged

Add jazzy #293

merged 13 commits into from
May 13, 2024

Conversation

christophfroehlich
Copy link
Contributor

let sphinx-multiversion create a page for Jazzy Jalisco, pointing to all rolling/master subrepos.
fyi: There is already one at https://docs.ros.org/

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophfroehlich The changes itself look good to me.
Maybe it is better to wait until the Tutorial party is done, before merging this

@christophfroehlich
Copy link
Contributor Author

@saikishor there is no hurry for merging it, but there won't be any changes necessary unless we branch the subrepos for jazzy

@saikishor
Copy link
Member

@saikishor there is no hurry for merging it, but there won't be any changes necessary unless we branch the subrepos for jazzy

Ofcourse, I agree. If that's the case, we can then merge it.

@christophfroehlich
Copy link
Contributor Author

Let's wait until Jazzy is included in index.ros.org and docs.ros.org/api

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem correct to me though I haven't fully understood the multiversion build, yet.

@christophfroehlich
Copy link
Contributor Author

christophfroehlich commented May 7, 2024

The changes seem correct to me though I haven't fully understood the multiversion build, yet.

The core setting is the smv_branch_whitelist: Every branch matching this regex will be built as a version during multiversion build. The other stuff is only for auto-replacement of macros in the docs, as well as checkout the correct branches of the subrepos.

@christophfroehlich
Copy link
Contributor Author

christophfroehlich commented May 13, 2024

After merging this, I'll rename the default branch of this repo from master to rolling (similar to https://github.com/ros2/ros2_documentation) to make sphinx-multiversion write "Rolling" instead of "Master"

Edit: This will not break old links, I copied the "master" html folder so that one will at least reach something useful.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants