-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jazzy #293
Add jazzy #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christophfroehlich The changes itself look good to me.
Maybe it is better to wait until the Tutorial party is done, before merging this
@saikishor there is no hurry for merging it, but there won't be any changes necessary unless we branch the subrepos for jazzy |
Ofcourse, I agree. If that's the case, we can then merge it. |
Let's wait until Jazzy is included in index.ros.org and docs.ros.org/api |
e370c55
to
faa8acd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes seem correct to me though I haven't fully understood the multiversion build, yet.
The core setting is the |
After merging this, I'll rename the default branch of this repo from master to rolling (similar to https://github.com/ros2/ros2_documentation) to make sphinx-multiversion write "Rolling" instead of "Master" Edit: This will not break old links, I copied the "master" html folder so that one will at least reach something useful. |
let sphinx-multiversion create a page for Jazzy Jalisco, pointing to all rolling/master subrepos.
fyi: There is already one at https://docs.ros.org/