Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributions to acknowledgement page #217

Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Jan 1, 2024

As requested by @bmagyar ;)

I suggest using tabs for the multiple tables now. Any preferences on what showing on top?

image

Implementation detail: the tabs.js from https://github.com/executablebooks/sphinx-tabs does not work with jQuery, I added it manually here and commented the last lines.
executablebooks/sphinx-tabs#189

@christophfroehlich
Copy link
Contributor Author

Btw: I just skip commits without authors, which means normally that the account doesn't exist (any more).

@destogl
Copy link
Member

destogl commented Jan 2, 2024

I suggest to add something to 12 Months tabs so one can recognize them. It could be something short like 12 Months Rev and 12 Months Contrib or even 12 Mo Reviews..., what do you think? I would start with contributions in the last 12 months.

@christophfroehlich
Copy link
Contributor Author

I suggest to add something to 12 Months tabs so one can recognize them. It could be something short like 12 Months Rev and 12 Months Contrib or even 12 Mo Reviews..., what do you think? I would start with contributions in the last 12 months.

I thought about the same, but I mean it is obviously after the second click ;) But I add something and change the default tab

@christophfroehlich
Copy link
Contributor Author

@destogl I updated the tabs, see the screenshot above. The only thing I'm not sure about is how well the tabs work with responsive design on mobile phones.

@destogl
Copy link
Member

destogl commented Jan 3, 2024

@destogl I updated the tabs, see the screenshot above. The only thing I'm not sure about is how well the tabs work with responsive design on mobile phones.

Looks great! Thanks! Regarding mobile phones, we don't have to optimize the page for now for it. 88% of visitors use desktop anyway.

@destogl
Copy link
Member

destogl commented Jan 3, 2024

You are welcome to merge at your convenience when check are passing. I am not sure if there is an error, or data is not available yet and will be later.

@christophfroehlich christophfroehlich merged commit b1b7e26 into ros-controls:master Jan 3, 2024
4 of 6 checks passed
@christophfroehlich christophfroehlich deleted the parse_contributions branch January 3, 2024 11:10
@christophfroehlich
Copy link
Contributor Author

Exactly, data is not available yet. and cache from PRs can't be accessed from master workflows -> cancelled.

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble iron

Copy link
Contributor

mergify bot commented Jan 4, 2024

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 4, 2024
(cherry picked from commit b1b7e26)

# Conflicts:
#	.github/workflows/pr-stats.yml
mergify bot pushed a commit that referenced this pull request Jan 4, 2024
(cherry picked from commit b1b7e26)

# Conflicts:
#	.github/workflows/pr-stats.yml
christophfroehlich added a commit that referenced this pull request Jan 4, 2024
* Add contributions to acknowledgement page (#217)

(cherry picked from commit b1b7e26)

# Conflicts:
#	.github/workflows/pr-stats.yml

* Fix typo

* Delete .github/workflows/pr-stats.yml

---------

Co-authored-by: Christoph Fröhlich <[email protected]>
christophfroehlich added a commit that referenced this pull request Jan 4, 2024
* Add contributions to acknowledgement page (#217)

(cherry picked from commit b1b7e26)

# Conflicts:
#	.github/workflows/pr-stats.yml

* Fix typo

* Delete .github/workflows/pr-stats.yml

---------

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants