-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contributions to acknowledgement page #217
Add contributions to acknowledgement page #217
Conversation
This reverts commit c18a3ba.
Btw: I just skip commits without authors, which means normally that the account doesn't exist (any more). |
I suggest to add something to |
I thought about the same, but I mean it is obviously after the second click ;) But I add something and change the default tab |
@destogl I updated the tabs, see the screenshot above. The only thing I'm not sure about is how well the tabs work with responsive design on mobile phones. |
Looks great! Thanks! Regarding mobile phones, we don't have to optimize the page for now for it. 88% of visitors use desktop anyway. |
You are welcome to merge at your convenience when check are passing. I am not sure if there is an error, or data is not available yet and will be later. |
Exactly, data is not available yet. and cache from PRs can't be accessed from master workflows -> cancelled. |
@Mergifyio backport humble iron |
✅ Backports have been created
|
(cherry picked from commit b1b7e26) # Conflicts: # .github/workflows/pr-stats.yml
(cherry picked from commit b1b7e26) # Conflicts: # .github/workflows/pr-stats.yml
* Add contributions to acknowledgement page (#217) (cherry picked from commit b1b7e26) # Conflicts: # .github/workflows/pr-stats.yml * Fix typo * Delete .github/workflows/pr-stats.yml --------- Co-authored-by: Christoph Fröhlich <[email protected]>
* Add contributions to acknowledgement page (#217) (cherry picked from commit b1b7e26) # Conflicts: # .github/workflows/pr-stats.yml * Fix typo * Delete .github/workflows/pr-stats.yml --------- Co-authored-by: Christoph Fröhlich <[email protected]>
As requested by @bmagyar ;)
I suggest using tabs for the multiple tables now. Any preferences on what showing on top?
Implementation detail: the tabs.js from https://github.com/executablebooks/sphinx-tabs does not work with jQuery, I added it manually here and commented the last lines.
executablebooks/sphinx-tabs#189