Member.php: also properly resolve monthly and yearly payments #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowa-Ammerlaan
force-pushed
the
yearly-and-monthly-payments
branch
15 times, most recently
from
15890f2 to
9e6660e
Compare
and register the first payment in the payments array so the new users show up as having paid in the xlsx database export. Closes: #203 Signed-off-by: Nowa Ammerlaan <[email protected]>
Nowa-Ammerlaan
force-pushed
the
yearly-and-monthly-payments
branch
from
9e6660e to
5d07a8b
Compare
Gwildor
approved these changes
Nov 17, 2024
Gwildor
reviewed
Dec 7, 2024
Comment on lines
+115
to
+121
| $init_payment->setPeriodMonthEnd($member->getRegistrationTime()->modify('+1 month')->format('n')); | ||
| break; | ||
| case $member::PERIOD_QUARTERLY: | ||
| $init_payment->setPeriodMonthEnd($member->getRegistrationTime()->modify('+3 month')->format('n')); | ||
| break; | ||
| case $member::PERIOD_ANNUALLY: | ||
| $init_payment->setPeriodMonthEnd($member->getRegistrationTime()->modify('+12 month')->format('n')); |
There was a problem hiding this comment.
Ik denk dat $member->getRegistrationTime()->modify('+12 month') in place muteert, waardoor dit #217 veroorzaakt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #203