Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[160] Fix error when saving member without email or birthday #185

Merged
merged 1 commit into from
May 19, 2024
+4 −4
Merged

[160] Fix error when saving member without email or birthday #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Entity/MemberDetailsRevision.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ class MemberDetailsRevision {
/** @ORM\Column(type="string", length=100) */
private string $lastName;

/** @ORM\Column(type="string", length=200) */
private string $email;
/** @ORM\Column(type="string", length=200, nullable=true) */
private ?string $email = null;

/** @ORM\Column(type="string", length=20) */
private string $phone;
Expand Down Expand Up @@ -102,7 +102,7 @@ public function hasChanged(Member $member) {
|| $this->getPostCode() !== $member->getPostCode()
|| $this->getCountry() !== $member->getCountry()
|| $this->getCurrentMembershipStatus() !== $member->getCurrentMembershipStatus()
|| $this->getDateOfBirth()->format('Ymd') !== $member->getDateOfBirth('Ymd');
|| $this->getDateOfBirth() !== $member->getDateOfBirth();
}

public function getId(): ?int { return $this->id; }
Expand All @@ -115,7 +115,7 @@ public function getAddress(): string { return $this->address; }
public function getCity(): string { return $this->city; }
public function getPhone(): string { return $this->phone; }
public function getIban(): ?string { return $this->iban; }
public function getEmail(): string { return $this->email; }
public function getEmail(): ?string { return $this->email; }
public function getPostCode(): string { return $this->postCode; }
public function getCountry(): string { return $this->country; }
public function getDateOfBirth(): ?DateTime { return $this->dateOfBirth; }
Expand Down
Loading