Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[144] Make contributions dynamic #167

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

Gwildor
Copy link
Collaborator

@Gwildor Gwildor commented Mar 27, 2024

Also fixed the validation which checks that the higher amount is higher than the highest tier. And fixed the clearing/setting of the higher amount radio button, which was working on the signup page but not on the contribution page, so I just copied it from the signup page and it worked.

ROOD:

Screenshot from 2024-03-27 16-50-39

de Socialisten:

Screenshot from 2024-03-27 16-50-08

Fixes #144. Also fixes #156.

Also fixed the validation which checks that the higher amount is higher
than the highest tier. And fixed the clearing/setting of the higher
amount radio button, which was working on the signup page but not on the
contribution page, so I just copied it from the signup page and it
worked.
Copy link
Member

@Nowa-Ammerlaan Nowa-Ammerlaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik dacht dat we percentages van netto inkomen deden. Otherwise LGTM.

@Gwildor Gwildor merged commit ff0d75c into main Apr 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributieschalen bruto/netto onduidelijk Contributie moet per instantie in te stellen zijn
2 participants