Merge pull request #175 from roodjong/145-configurable-max-age

[145] Make min and max age of signup configurable
roodjong · May 19, 2024 · 4ea83f8 · 4ea83f8
2 parents 66c8c1d + 71f7a6d
commit 4ea83f8
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 3 deletions.
diff --git a/config/instances/ds.yaml b/config/instances/ds.yaml
@@ -4,3 +4,6 @@ contribution:
       description: Studenten en werklozen
     - amount: null
       description: "Werkenden: 0,5% van het netto inkomen (minimaal €15 per kwartaal)"
+signup:
+  min_age: 16
+  max_age: null
diff --git a/config/instances/rood.yaml b/config/instances/rood.yaml
@@ -8,3 +8,6 @@ contribution:
       description: €3500 bruto en daarboven
     - amount: null
       description: ik betaal een hogere contributie, namelijk:
+signup:
+  min_age: 14
+  max_age: 27
diff --git a/src/Controller/MemberController.php b/src/Controller/MemberController.php
@@ -94,6 +94,8 @@ public function apply(Request $request): Response {
         $membershipApplication->setRegistrationTime(new \DateTime());
         $membershipApplication->setContributionPeriod(Member::PERIOD_QUARTERLY);
         $form = $this->createForm(MembershipApplicationType::class, $membershipApplication, [
+            'min_age' => $org_config['signup']['min_age'],
+            'max_age' => $org_config['signup']['max_age'],
             'use_middle_name' => $this->getParameter('app.useMiddleName'),
             'privacy_policy_url' => $this->getParameter('app.privacyPolicyUrl'),
             'organization_name' => $this->getParameter('app.organizationName'),

diff --git a/src/DataFixtures/MemberFixtures.php b/src/DataFixtures/MemberFixtures.php
@@ -29,6 +29,7 @@ public function load(ObjectManager $manager)
         $divisionNooderhaaks = new Division();
         $divisionNooderhaaks->setName("Noorderhaaks");
         $divisionNooderhaaks->setPostCode("1234AB");
+        $divisionNooderhaaks->setCanBeSelectedOnApplication(true);
 
         $contactNooderhaaks = new Member();
         $contactNooderhaaks->setId(1338);
@@ -45,6 +46,7 @@ public function load(ObjectManager $manager)
         $divisionAchterhoek = new Division();
         $divisionAchterhoek->setName("Achterhoek");
         $divisionAchterhoek->setPostCode("4321BA");
+        $divisionAchterhoek->setCanBeSelectedOnApplication(true);
 
         $contactAchterhoek = new Member();
         $contactAchterhoek->setId(8673);

diff --git a/src/Form/MembershipApplicationType.php b/src/Form/MembershipApplicationType.php
@@ -25,14 +25,31 @@ public function buildForm(FormBuilderInterface $builder, array $options)
         $builder
             ->add('lastName', null, ['label' => 'Achternaam', 'error_bubbling' => true, 'constraints' => [new NotBlank()]])
             ->add('email', null, ['label' => 'E-mailadres', 'error_bubbling' => true, 'constraints' => [new NotBlank()]])
-            ->add('phone', null, ['label' => 'Telefoonnummer', 'error_bubbling' => true, 'constraints' => [new NotBlank()]])
+            ->add('phone', null, ['label' => 'Telefoonnummer', 'error_bubbling' => true, 'constraints' => [new NotBlank()]]);
+
+        if ($options['max_age']) {
+            $age_constraint = new Age([
+                'min' => $options['min_age'],
+                'max' => $options['max_age'],
+                'message' => 'Je moet tussen de {{ min }} en {{ max }} jaar oud zijn om lid te worden van ' . $options['organization_name'] . '.'
+            ]);
+        } else {
+            $age_constraint = new Age([
+                'min' => $options['min_age'],
+                'message' => 'Je moet minimaal {{ min }} jaar oud zijn om lid te worden van ' . $options['organization_name'] . '.'
+            ]);
+        }
+
+        $builder
             ->add('dateOfBirth', null, [
                 'label' => 'Geboortedatum',
                 'required' => true,
                 'widget' => 'single_text',
-                'constraints' => [new NotBlank(), new Age(['min' => 14, 'max' => 27, 'message' => 'Je moet tussen de {{ min }} en {{ max }} jaar oud zijn om lid te worden van ROOD.'])],
+                'constraints' => [new NotBlank(), $age_constraint],
                 'error_bubbling' => true
-            ])
+            ]);
+
+        $builder
             // ->add('iban', null, ['label' => 'IBAN-rekeningnummer', 'error_bubbling' => true])
             ->add('address', null, ['label' => 'Adres', 'error_bubbling' => true, 'constraints' => [new NotBlank()]])
             ->add('city', null, ['label' => 'Plaats', 'error_bubbling' => true, 'constraints' => [new NotBlank()]])
@@ -83,5 +100,13 @@ public function configureOptions(OptionsResolver $resolver)
         $resolver->setRequired([
             'contribution'
         ]);
+
+        $resolver->setRequired([
+            'min_age'
+        ]);
+
+        $resolver->setRequired([
+            'max_age'
+        ]);
     }
 }