fix(registration date): fixed member registration date being 3 months…

… into the future
roodjong · Dec 23, 2024 · 23005d0 · 23005d0
1 parent 047517e
commit 23005d0
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/Controller/Admin/MembershipApplicationCrud.php b/src/Controller/Admin/MembershipApplicationCrud.php
@@ -110,15 +110,17 @@ public function acceptApplication(AdminContext $context)
             $init_payment->setPaymentTime($member->getRegistrationTime());
             $init_payment->setPeriodYear($member->getRegistrationTime()->format('Y'));
             $init_payment->setPeriodMonthStart($member->getRegistrationTime()->format('n'));
+            # cloning object, so the original DateTime object will not be modified
+            $registration_date = clone $member->getRegistrationTime();
             switch ($member->getContributionPeriod()) {
                 case $member::PERIOD_MONTHLY:
-                    $init_payment->setPeriodMonthEnd($member->getRegistrationTime()->modify('+1 month')->format('n'));
+                    $init_payment->setPeriodMonthEnd($registration_date->modify('+1 month')->format('n'));
                     break;
                 case $member::PERIOD_QUARTERLY:
-                    $init_payment->setPeriodMonthEnd($member->getRegistrationTime()->modify('+3 month')->format('n'));
+                    $init_payment->setPeriodMonthEnd($registration_date->modify('+3 month')->format('n'));
                     break;
                 case $member::PERIOD_ANNUALLY:
-                    $init_payment->setPeriodMonthEnd($member->getRegistrationTime()->modify('+12 month')->format('n'));
+                    $init_payment->setPeriodMonthEnd($registration_date->modify('+12 month')->format('n'));
                     break;
                 default:
                     throw new \Exception('Period must be PERIOD_MONTHLY, PERIOD_QUARTERLY or PERIOD_ANNUALLY');