Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #716
As discussed,
SSHConnection
now has a_tasks
attribute. Created tasks are stored in it and removed when they are done.When
wait_closed
is called, all running tasks are awaited.What i am unsure about: should aborting the connection cancel all running tasks? The idea here is that there needs to be a way to stop tasks that never finish. The user can try to close the connection gracefully, wait for it to close with a timeout and abort the connection if the timeout is exceeded.
The
abort()
method itself seems to be the right place to cancel all tasks, as_force_close()
and_cleanup()
are also called in a normal close/disconnect operation, so cancelling all tasks there would make awaiting them pointless