Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of Cow<'static, str> in PrettyConfig #546

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Make use of Cow<'static, str> in PrettyConfig #546

merged 1 commit into from
Sep 12, 2024

Conversation

Coca162
Copy link
Contributor

@Coca162 Coca162 commented Sep 11, 2024 •
edited
Loading

Fixes #545 by moving all String fields in PrettyConfig to Cow<'static, str>, builder methods are updated to take in impl Into<Cow<'static, str>>. I've also removed any conversions to strings in tests/other parts of the codebase.

  • I've included my change in CHANGELOG.md

juntyr
juntyr approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juntyr
Copy link
Member

juntyr commented Sep 12, 2024

Thank you @Coca162 for the PR and @maypop-the-dragon for bringing up the issue :)

@juntyr juntyr merged commit 761bfc6 into ron-rs:master Sep 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juntyr juntyr juntyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please use Cow<'static, str> for configuration, rather than String.
2 participants
@Coca162 @juntyr