Fixup --log-filters documentation and examples
#618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following #606 (comment) |
Kixunil
suggested changes
Nov 12, 2021
There was a problem hiding this comment.
I think it'd be good to add a table like this somewhere:
| Log level | Old verbose value | Description |
|---|---|---|
| ERROR | 0 | Only fatal errors |
| WARN | 1 | Things that could indicate serious problems |
| INFO | 2 | Various significant events and suggestions |
| DEBUG | 3 | Details that could be useful when debugging - only use when debugging! |
| TRACE | 4 | Very detailed information - only use when debugging! |
doc/upgrading.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| * If you use `verbose` (or `-v` argument), switch to `log_filters` (or `RUST_LOG` environment variable). | |||
| Please note that it allows to set per-module filters, but module naming is considered unstable. | |||
| If you have used `-vv` (the default setting), switch to `--log-filters INFO`. | |||
There was a problem hiding this comment.
I think this should say "the value suggested in the documentation" instead of "the default setting" since the default was ERROR.
romanz
force-pushed
the
fix-verbosity
branch
2 times, most recently
from
0d8fc34 to
fdffd3c
Compare
romanz
force-pushed
the
fix-verbosity
branch
from
fdffd3c to
a90871a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
-vand--verbosementions.