Updated backtrace and relevant dependencies #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates `cc`, `memchr` and `backtrace` to hopefully fix romanz#453. It looks like a memory leak was fixed in a new version but I'm not sure if relevant now. See rust-lang/rust#59125 (comment)
|
Oh, I see MSRV got bumped, perhaps it will work on top of #455 This is a bit challenging: RPi users may be unable to upgrade rustc but without it they may experience crashes with Maybe a correct combination of dependencies that fixes this can be found anyway, but I don't have time to try right now. If it turns out the fix requires MSRV bump then maybe the correct strategy is to bump MSRV in version |
Kixunil
added a commit
to Kixunil/electrs
that referenced
this pull request
Aug 20, 2021
This may fix an issue with memory leak but not yet tested. This change should NOT require MSRV bump. See romanz#459 and romanz#453
|
Closing since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
cc,memchrandbacktraceto hopefully fix #453.It looks like a memory leak was fixed in a new version but I'm not sure
if relevant now.
See rust-lang/rust#59125 (comment)
I didn't test yet, first going to let CI do it.