Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pluginutils,node-resolve): replace test with includes #1787

Merged

Conversation

btea
Copy link
Contributor

@btea btea commented Oct 15, 2024

Rollup Plugin Name: {pluginutils,node-resolve}

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

It seems that includes are much more efficient than test. jsbenchmark

@shellscape shellscape changed the title refactor: replace test with includes refactor(pluginutils,node-resolve): replace test with includes Oct 16, 2024
@shellscape
Copy link
Collaborator

Thanks for the PR. Looks like these changed cause a lot of test failures.

@btea
Copy link
Contributor Author

btea commented Oct 16, 2024

Thanks for the review, I will check it out.

@shellscape shellscape merged commit 4cfc1c3 into rollup:master Dec 15, 2024
5 checks passed
@btea btea deleted the refactor/use-replace-test-with-includes branch December 16, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants