Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version in master branch #989

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

boatbomber
Copy link
Member

We've been cutting releases from branches, so the master branch doesn't have the latest version. This means we get the update notif when developing from master, and might lead to accidentally releasing with 7.4.1 later

@boatbomber boatbomber added scope: plugin Relevant to the Roblox Studio plugin type: tech debt Internal work that needs to happen skip changelog PRs that may skip the changelog enforcement check labels Nov 6, 2024
@boatbomber boatbomber requested a review from Dekkonot November 6, 2024 02:06
@boatbomber boatbomber enabled auto-merge (squash) November 6, 2024 02:07
@boatbomber boatbomber disabled auto-merge November 6, 2024 02:07
@boatbomber boatbomber merged commit 4a7bddb into rojo-rbx:master Nov 6, 2024
6 checks passed
@boatbomber boatbomber deleted the update-master-version branch November 6, 2024 02:10
kennethloeffler added a commit that referenced this pull request Nov 6, 2024
<p dir="auto">in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2636858743" data-permission-text="Title is private" data-url="#989" data-hovercard-type="pull_request" data-hovercard-url="//pull/989/hovercard" href="https://github.com/rojo-rbx/rojo/pull/989">#989</a>, we changed Rojo's version number on the master branch to 7.4.4. This is a little odd, because 7.4.4 is already released, is diverged from the master branch, and we are not working towards 7.4.4 on the master branch. If we're going to spend time on this, I think we should use a more appropriate version number.</p>
<p dir="auto">This PR changes the version number to 7.5.0-prealpha, since Rojo's master branch is currently undergoing development towards 7.5.0. We will most likely <strong>not</strong> be making a release of this version - the only intent is better clarity for those running Rojo's latest master.</p>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: plugin Relevant to the Roblox Studio plugin skip changelog PRs that may skip the changelog enforcement check type: tech debt Internal work that needs to happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants