Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sync reminder more detailed #987

Merged

Conversation

boatbomber
Copy link
Member

Closes #986.

The sync reminder notification will now tell you what you synced and when you synced it.

Example: You synced project 'LuaLearning' to this place 2 hours ago. Would you like to reconnect?

If there's no known project name, it'll fallback to: You synced localhost:34872 to this place 2 hours ago. Would you like to reconnect?
This should only happen once per place, since the existing save data you have before this update didn't store the project name.

@Dekkonot Dekkonot added scope: plugin Relevant to the Roblox Studio plugin skip changelog PRs that may skip the changelog enforcement check labels Nov 5, 2024
@Dekkonot
Copy link
Member

Dekkonot commented Nov 5, 2024

By my mark doesn't need a changelog entry and looks good to me

@boatbomber boatbomber enabled auto-merge (squash) November 5, 2024 22:47
@boatbomber boatbomber merged commit e316fdb into rojo-rbx:master Nov 5, 2024
6 checks passed
@boatbomber boatbomber deleted the feature/improve-reconnect-prompt branch November 5, 2024 22:47
@Dekkonot Dekkonot removed the skip changelog PRs that may skip the changelog enforcement check label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: plugin Relevant to the Roblox Studio plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show previous name of project in sync prompt
2 participants