-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for compatible updates in plugin #832
Conversation
I'm of two minds here. The first loves this because it'd serve as a reminder for people to actually update their dang Rojo releases. The second thinks this'll be annoying and that prompting people for pre-releases might be a problem since we don't plan to publish the plugin to the website for those versions. I appreciate how you can turn it off but I'm not sure how much I like a feature that my first thought was "I hope you can turn it off" for. |
You're correct in that prereleases are likely to cause more confusion for marketplace users... Should I disable that subsetting when installed via marketplace? I can detect that pretty easily. |
If you install Rojo via marketplace, the Include Prerelease setting is hidden to avoid confusion. |
…in-update-notif
…in-update-notif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reconsidered this and I think we should include it, haha.
Adds a setting to checking for updates.
When a newer compatible version is detected, it gives the user a notification. It will not notify about major version updates, since those are potentially breaking and the user may have reason to remain on the older version.
When the setting is enabled in a local install (ie: not the marketplace published plugin), it also adds a setting for being notified about prereleases (defaults to off).
This should hopefully reduce the number of reports we get from people simply using outdated versions.