Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for compatible updates in plugin #832

Merged
merged 22 commits into from
Aug 5, 2024

Conversation

boatbomber
Copy link
Member

@boatbomber boatbomber commented Jan 5, 2024

Adds a setting to checking for updates.
image

When a newer compatible version is detected, it gives the user a notification. It will not notify about major version updates, since those are potentially breaking and the user may have reason to remain on the older version.

image

When the setting is enabled in a local install (ie: not the marketplace published plugin), it also adds a setting for being notified about prereleases (defaults to off).

image

image

This should hopefully reduce the number of reports we get from people simply using outdated versions.

@boatbomber boatbomber added type: enhancement Feature or improvement that should potentially happen scope: plugin Relevant to the Roblox Studio plugin size: small status: in-progress Someone is working on this last time we checked. labels Jan 5, 2024
@boatbomber boatbomber self-assigned this Jan 5, 2024
@boatbomber boatbomber marked this pull request as ready for review January 5, 2024 21:24
@boatbomber boatbomber added status: needs review This work is mostly done, but just needs work to integrate and merge it. and removed status: in-progress Someone is working on this last time we checked. labels Jan 5, 2024
@boatbomber boatbomber added status: needs decision We need to figure out what the resolution to this is. and removed status: needs review This work is mostly done, but just needs work to integrate and merge it. labels Jan 17, 2024
@Dekkonot
Copy link
Member

I'm of two minds here.

The first loves this because it'd serve as a reminder for people to actually update their dang Rojo releases.

The second thinks this'll be annoying and that prompting people for pre-releases might be a problem since we don't plan to publish the plugin to the website for those versions. I appreciate how you can turn it off but I'm not sure how much I like a feature that my first thought was "I hope you can turn it off" for.

@boatbomber
Copy link
Member Author

boatbomber commented Jan 23, 2024

You're correct in that prereleases are likely to cause more confusion for marketplace users... Should I disable that subsetting when installed via marketplace? I can detect that pretty easily.

@boatbomber
Copy link
Member Author

If you install Rojo via marketplace, the Include Prerelease setting is hidden to avoid confusion.

@boatbomber boatbomber requested a review from Dekkonot July 26, 2024 04:26
Copy link
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reconsidered this and I think we should include it, haha.

@Dekkonot Dekkonot merged commit 4b5db4e into rojo-rbx:master Aug 5, 2024
6 checks passed
@boatbomber boatbomber deleted the plugin-update-notif branch August 5, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: plugin Relevant to the Roblox Studio plugin size: small status: needs decision We need to figure out what the resolution to this is. type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants