Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for Glofas stations #1796

Conversation

Piotrk39
Copy link
Contributor

@Piotrk39 Piotrk39 commented Nov 19, 2024

Describe your changes

Adds E2E test for max warning GloFAS stations not being present on the map while in [No-Trigger]

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

@Piotrk39 Piotrk39 marked this pull request as ready for review November 19, 2024 13:28
@Piotrk39 Piotrk39 added enhancement New feature or request test This involves testing labels Nov 19, 2024
Copy link
Contributor

@jannisvisser jannisvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and clear to me!

@jannisvisser jannisvisser merged commit 1c015da into master Nov 19, 2024
8 checks passed
@jannisvisser jannisvisser deleted the feat.add-e2e-test-for-no-max-warning-markers-visible-in-no-trigger branch November 19, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test This involves testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E test: [No-trigger] ONLY No trigger, medium warning, and low warning GloFAS stations should be visible
2 participants