Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Update for Gnome 3.32 #40

Merged
merged 1 commit into from
May 10, 2019
Merged

🐛 Update for Gnome 3.32 #40

merged 1 commit into from
May 10, 2019

Conversation

Striffly
Copy link
Contributor

@Striffly Striffly commented Apr 12, 2019 •
edited
Loading

The icon is missing, but everything else works.
If someone know how to fix the icon please do a PR on my fork ! :)

@eode
Copy link

eode commented Apr 17, 2019

Can confirm that this works, mostly, but needs the following:

  • Icon (as @Striffly mentioned)
  • Completely remove when turned off (prevents turning back on again)
  • Don't crash if no folder is set

@eode
Copy link

eode commented Apr 17, 2019

..took a stab at the icon issue, but ran out of time. :-(

@rugk
Copy link

rugk commented May 1, 2019

Maybe add "Fixes #41".

@rugk rugk mentioned this pull request May 1, 2019
Open
@rodakorn rodakorn merged commit 36d3d6f into rodakorn:master May 10, 2019
@Striffly
Copy link
Contributor Author

Striffly commented May 10, 2019 •
edited
Loading

Can confirm that this works, mostly, but needs the following:

* Icon (as @Striffly mentioned)

* Completely remove when turned off (prevents turning back on again)

* Don't crash if no folder is set

@rodakorn don't forget this please ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frnogueira frnogueira frnogueira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Striffly @eode @rugk @frnogueira @rodakorn