More aggressive typekit lookup #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replayHandler.stop is done by allowing the main playback loop to exit.
This also reworks some of the plumbing to not only rely on std::pair<std::string,std::string> types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a single pass of orocos_cpp::PluginHelper::loadAllTypekitAndTransports() if a tasks model name cannot be used for its typekit lookup. This ensures that samples from any of the already installed typekits can be replayed even if the task has not been installed.
This does not prevent a type mismatch when the log file has a different type with the same name. To get that case working, one would need to construct a typekit on-the-fly from the information in the streams type registry.
The rest fixes a problem where OrocosCpp was instantiated twice, preventing the above to be debugged properly because the logtaskmanagers orocos instance would not be initialized properly, and displays the unreplayable ports in the gui instead of a) not having the task or b) not having the port, without any indication what is going on.