fix: telemetry v2 improvements #449
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Orocos::Async implementation needs to be re-done. I'm de-facto starting this here, focusing on the Syskit telemetry agent as the remote agent, instead of a generic RTT-focussed implementation This does not need the agent, but already helps a lot with the performance
IORs are ... actually big. The call at 10Hz is currently taking 1 MB/s. Implement the incremental version right away to keep the bandwidth small All work on the telemetry MUST have a corresponding bandwidth measurement to avoid this kind of surprises.
This load local task models, which is both heavy and useless (since the code is not using the model at all for now). Do not load anything for the time being. The right thing long-term is to use the remote model
A well-unit-tested combination of UI::NameService and the async-update code from UI::RuntimeState
… by Async::NameService
We seldom use it, and it actually is very heavy on CPU
It's seldom usable as it is.
…more It will be applied on next update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with the most obvious problems related to the telemetry v2.