feat(zero-cache): improve the error message for unsupported protocol versions #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
darkgnotic
deleted the
darkgnotic/better-protocol-version-error-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers seem to hit protocol version mismatches often, usually when running client code that's newer than server code:
https://discord.com/channels/830183651022471199/1288232858795769917/1321105123224715315
https://discord.com/channels/830183651022471199/1322659299717287946/1322706138126614630
Improve the error message returned by the
zero-cacheto specify which component should be updated to a newer release.Also make the deprecation of older protocol versions explicit with a
MIN_SERVER_SUPPORTED_PROTOCOL_VERSIONconstant, rather than forcingPROTOCOL_VERSION - 1. Since protocol version deprecation generally involves manual cleanup (i.e. of old code), the support boundary should also be manually updated.