fix(zero-cache): fix replication of TRUNCATE statements #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
arv
reviewed
Jan 6, 2025
Comment on lines
+228
to
230
| constructor(msg: string) { | ||
| super(msg); | ||
| } |
There was a problem hiding this comment.
you can remove the constructor now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncates were initially processed by converting the TRUNCATE event into a sequence of
delpatches that were to be pushed through IVM pipelines. This never worked, as the generation of this sequence opened an iterator over theprevdatabase handle, and that database needs to be concurrently advanced by the IVM push.Instead, truncates are now processed in the same manner as that of schema changes; the advancement is aborted and pipelines are rehydrated from the
currdatabase handle.