fix(zero-cache): windows friendly fork and import calls

rocicorp · Dec 23, 2024 · b5dd861 · b5dd861
1 parent 8c0492c
commit b5dd861
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 34 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/zero-cache/package.json b/packages/zero-cache/package.json
@@ -59,7 +59,7 @@
     "@types/lodash.kebabcase": "^4.1.9",
     "@types/lodash.merge": "^4.6.9",
     "@types/lodash.snakecase": "^4.1.9",
-    "@types/node": "^18.16.0",
+    "@types/node": "^20.8.4",
     "@types/pg": "^8.11.2",
     "@types/pg-format": "^1.0.5",
     "@types/strip-ansi": "^3.0.0",

diff --git a/packages/zero-cache/src/types/processes.ts b/packages/zero-cache/src/types/processes.ts
@@ -159,13 +159,13 @@ export function childWorker(
   const ext = path.extname(import.meta.url);
   // modulePath is .ts. If we have been compiled, it should be changed to .js
   modulePath = modulePath.replace(/\.ts$/, ext);
-  const absModulePath = new URL(`../${modulePath}`, import.meta.url).pathname;
+  const moduleUrl = new URL(`../${modulePath}`, import.meta.url);
 
   args.push(...process.argv.slice(2));
 
   if (singleProcessMode()) {
     const [parent, child] = inProcChannel();
-    import(absModulePath)
+    import(moduleUrl.href)
       .then(({default: runWorker}) =>
         runWorker(parent, env ?? process.env, ...args).then(
           () => child.emit('close', 0),
@@ -176,7 +176,7 @@ export function childWorker(
     return child;
   }
   return wrap(
-    fork(absModulePath, args, {
+    fork(moduleUrl, args, {
       detached: true, // do not automatically propagate SIGINT
       serialization: 'advanced', // use structured clone for IPC
       env,