fix: Do not access global crypto (#1978)

Instead go through shared/src/crypto.ts which will use the global crypto
if available, and fallback node's crypto module if not.

packages/reflect-client/src/util/nanoid.ts

@@ -1,3 +1,5 @@
+import * as crypto from 'shared/src/crypto.js';
+
 // This is taken from https://github.com/ai/nanoid/blob/main/index.browser.js We
 // copy this because we want to use `--platform=neutral` which doesn't work with
 // the npm package

packages/reflect/tool/build.js

@@ -115,7 +115,7 @@ async function buildPackages() {
     'reflect-shared',
     'reflect-react',
   );
-  external.push('node:diagnostics_channel');
+  external.push('node:*', 'crypto');
 
   await esbuild.build({
     ...shared,

packages/replicache/src/sync/request-id.ts

@@ -1,3 +1,4 @@
+import * as crypto from 'shared/src/crypto.js';
 import type {ClientID} from './ids.js';
 
 let sessionID = '';

packages/replicache/tool/build.js

@@ -33,11 +33,13 @@ const dirname = path.dirname(fileURLToPath(import.meta.url));
  */
 async function buildReplicache(options) {
   const define = await makeDefine(options.mode);
-  const {ext, mode, external, ...restOfOptions} = options;
+  const {ext, mode, external = [], ...restOfOptions} = options;
+  // crypto is used as a fallback in older node versions
+  external.push('node:*', 'crypto');
   const outfile = path.join(dirname, '..', 'out', 'replicache.' + ext);
   const result = await esbuild.build({
     ...sharedOptions(options.minify, metafile),
-    ...(external ? {external} : {}),
+    external,
     ...restOfOptions,
     format: 'esm',
     // Use neutral to remove the automatic define for process.env.NODE_ENV

packages/shared/src/crypto.ts

@@ -2,13 +2,20 @@
 
 // Firebase and Jest do not correctly setup the global crypto object.
 
+// Don't inline this. It is done this way to prevent TS from type checking the
+// module as well as to prevent esbuild (actually web-dev-server which does not
+// support external) from trying to resolve the module.
+const cryptoNodeModuleName = 'crypto';
+
 const localCrypto =
   typeof crypto !== 'undefined'
     ? crypto
-    : ((await import('crypto')).webcrypto as Crypto);
+    : ((await import(cryptoNodeModuleName)).webcrypto as Crypto);
 
 export function getRandomValues<T extends ArrayBufferView | null>(array: T): T {
   return localCrypto.getRandomValues(array);
 }
 
-export const {subtle} = localCrypto;
+// rollup does not like `export const {subtle} = ...
+// eslint-disable-next-line prefer-destructuring
+export const subtle = localCrypto.subtle;

packages/shared/tsconfig.json

@@ -1,8 +1,7 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    // For crypto when running under jest
-    "lib": ["dom"]
+    "noEmit": true
   },
   "include": ["src/**/*.ts", "src/**/*.js"]
 }

packages/zero-client/src/util/nanoid.ts

@@ -1,3 +1,5 @@
+import * as crypto from 'shared/src/crypto.js';
+
 // This is taken from https://github.com/ai/nanoid/blob/main/index.browser.js We
 // copy this because we want to use `--platform=neutral` which doesn't work with
 // the npm package

packages/zero-client/tool/build.js

@@ -33,10 +33,13 @@ async function buildPackages() {
   const define = makeDefine();
 
   fs.rmSync(basePath('out'), {recursive: true, force: true});
+  const external = await getExternalFromPackageJSON(import.meta.url);
+  // crypto is used as a fallback in older node versions
+  external.push('node:*', 'crypto');
 
   await esbuild.build({
     ...shared,
-    external: await getExternalFromPackageJSON(import.meta.url),
+    external,
     platform: 'browser',
     define: {
       ...define,