-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split scenario
and gym-ignition
Python packages
#346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoferigo
changed the title
Split scenario and gym-ignition
Split May 7, 2021
scenario
and gym-ignition
Python packages
diegoferigo
force-pushed
the
feature/split_scenario
branch
8 times, most recently
from
May 9, 2021 21:01
5bf754b
to
4a0828c
Compare
1 task
diegoferigo
force-pushed
the
feature/split_scenario
branch
from
May 12, 2021 07:18
e30d755
to
ef334ba
Compare
This was referenced May 12, 2021
Waiting the decision on the PyPI name in the dedicated issue, maybe we can start moving this forward with the |
diegoferigo
force-pushed
the
feature/split_scenario
branch
2 times, most recently
from
May 20, 2021 22:04
610cedf
to
f5fc0f1
Compare
diegoferigo
force-pushed
the
feature/split_scenario
branch
2 times, most recently
from
May 21, 2021 08:41
895dbdd
to
da53b65
Compare
diegoferigo
force-pushed
the
feature/split_scenario
branch
from
May 21, 2021 10:33
da53b65
to
0f33bc1
Compare
diegoferigo
force-pushed
the
feature/split_scenario
branch
3 times, most recently
from
May 21, 2021 14:25
1e18c60
to
3445566
Compare
traversaro
approved these changes
May 21, 2021
diegoferigo
force-pushed
the
feature/split_scenario
branch
from
May 21, 2021 19:24
3445566
to
ee8022e
Compare
diegoferigo
force-pushed
the
feature/split_scenario
branch
2 times, most recently
from
May 21, 2021 21:27
a351ac7
to
c83200d
Compare
diegoferigo
force-pushed
the
feature/split_scenario
branch
from
May 21, 2021 21:53
c83200d
to
4e5e69e
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #344. After this change, it should be more clear that gym-ignition is meant for RL applications, and scenario for a more broad use that is not related to RL. Those interested in just
scenario
can avoid to install alsogym-ignition
.setup.py
) in thescenario
folder, formercpp
.gym-ignition
pure Python package now depends fromscenario
.CI/CD pipeline changes:
Build and Test
job can be integrated more easily with conda (Test conda installation #279, Add workflow using conda to install dependencies #313)scenario
wheels for both Python 3.8 and 3.9scenario
andgym-ignition
TODO:
scenario
README that will be included in the new PyPI packageClaim theUsingscenario
PyPI package (PEP 541 Request:scenario
pypi/support#1082)scenar-io
while waiting.scenario
andgym-ignition
, otherwise generate a new one