-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force loading tensorflow shared libraries to prevent segfault #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me. Do you know if there is any python way for permit users to opt out/disable this workaround?
I think we can use an ad-hoc environment variable, such as |
Ouch, something's wrong in CI with idyntree and numpy:
Edit: I have the feeling that iDyntree is compiled against a new version of numpy is its isolated environment (that is clean and temporary), but outside numpy is older. This can be caused by some of the dependencies of the packages installed in the active Python environment having a Similar issues freqtrade/freqtrade#4281, https://github.com/cvxgrp/cvxpy/issues/1229.
|
3317133
to
e3ea127
Compare
e3ea127
to
21becc5
Compare
CI is still failing, this time in the IK test. The CI is building the wheel from the cba57f6 should solve the problem. |
I'm sorry 😔 |
@GiulioRomualdi Using kwargs is not mandatory, but it's useful to provide more context that often would require referring to the documentation. The price to pay is a more tight alignment with upstream that occasionally triggers minor problems like this one. No problem at all ;) Actually the span-based methods could be quite useful also to Python, but I fear that for exploiting them the most, pybind11 is necessary (and here we're based on SWIG). |
The segfault is a know problem and it is already documented in the FAQs:
https://github.com/robotology/gym-ignition/blob/321df6a2f93da829682ead2f428022ec1c4ef416/docs/sphinx/info/faq.rst#L4-L18
This PR is an attempt to prevent the occurrence, similar to apache/arrow#2210. Additional information can be found in #279 (comment).
Note that loading only the shared libraries is much faster than loading the entire
tensorflow
package.