Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial choice of exec command #38

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

robertpsoane
Copy link
Owner

  • First pass at offering user choice as to exec command
  • There is an open question as to whether or not to offer a "default exec" action along with a "detailed exec" action
  • This also forms the basis of how I might implement the run container feature - though this will need some sort of scrolling
  • Also want to add some sort of "single-use-autocompletion" wherein the default exec command is faded but can be tabbed to completion

@robertpsoane robertpsoane force-pushed the rs/optional-exec-command branch from adf0fe6 to 1cc6086 Compare July 8, 2024 20:05
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 106 lines in your changes missing coverage. Please review.

Files Coverage Δ
src/components/text_input_wrapper.rs 0.00% <0.00%> (ø)
src/pages/describe.rs 0.00% <0.00%> (ø)
src/widgets/text_input.rs 0.00% <0.00%> (ø)
src/docker/container.rs 0.00% <0.00%> (ø)
src/pages/attach.rs 0.00% <0.00%> (ø)

@robertpsoane robertpsoane merged commit 407e8c9 into master Jul 8, 2024
12 checks passed
@robertpsoane robertpsoane deleted the rs/optional-exec-command branch July 8, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant