refactor(pages): simplify page lifecycle removing the redundant concept of visibility #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt of visibility - In the first pass of the Containers and Images pages, there was a concept of "visibility"; this was before the Page trait had been added - This removes the concept of visibility (and the corrolorary call to `initialise` - Instead there is a single `initialise` method - Where clean-up is required for a page, there is a `Close` trait that must be implemented by all Pages - The close method has a default behaviour, this could go in a simple procedural macro with time but for now it just falls back on the default behaviour where no clean-up is requried for the page
Codecov ReportAttention: Patch coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first pass of the Containers and Images pages, there was a concept of "visibility"; this was before the Page trait had been added
This removes the concept of visibility (and the corrolorary call to
initialiseInstead there is a single
initialisemethodWhere clean-up is required for a page, there is a
Closetrait that must be implemented by all PagesThe close method has a default behaviour, this could go in a simple procedural macro with time but for now it just falls back on the default behaviour where no clean-up is requried for the page