Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use parent title as fallback when none is specified #75

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use parent title as fallback when none is specified #75

wants to merge 2 commits into from

Conversation

rinick
Copy link

@rinick rinick commented Dec 2, 2020

when title is not specified, it's better to show the title of original page instead of "Untitled"

rmariuzzo
rmariuzzo approved these changes Nov 28, 2022
View reviewed changes
Copy link
Owner

@rmariuzzo rmariuzzo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will wait to add that change somewhere in the docs.

@rmariuzzo rmariuzzo changed the title copy the title of current page by default Use parent title as fallback when none is specified Nov 28, 2022
@rmariuzzo rmariuzzo added this to the next milestone Nov 28, 2022
@rmariuzzo rmariuzzo self-assigned this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmariuzzo rmariuzzo rmariuzzo approved these changes

Assignees

@rmariuzzo rmariuzzo

Labels
api change update docs
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
2 participants
@rinick @rmariuzzo