Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashconsing example using the hashconsing library #38

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

craff
Copy link
Collaborator

@craff craff commented Jul 5, 2024

No description provided.

@craff craff requested a review from rlepigre July 5, 2024 18:45
@@ -24,4 +24,5 @@
(dune :build)
(timed (and (>= 1.0) :with-test))
(pacomb (and (>= 1.1) :with-test))
(hashcons :with-test)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a version bound.

Suggested change
(hashcons :with-test)
(hashcons (and (>= 1.4.0) :with-test))

@rlepigre rlepigre self-assigned this Jul 5, 2024
Copy link
Owner

@rlepigre rlepigre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, it is fine to add dependencies as long as they are identified as only for tests in the opam file. We might need to tweak CI though before we merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants