Skip to content

Commit

Permalink
Merge pull request rook#13072 from travisn/crash-keyring
Browse files Browse the repository at this point in the history
core: Crash collector keyring requires rw access for the mgr profile
  • Loading branch information
travisn authored Oct 23, 2023
2 parents 9d214b9 + a421143 commit ffaf4a1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pkg/operator/ceph/cluster/nodedaemon/keyring.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const (
[client.crash]
key = %s
caps mon = "allow profile crash"
caps mgr = "allow profile crash"
caps mgr = "allow rw"
`
)

Expand All @@ -59,7 +59,7 @@ func CreateCrashCollectorSecret(context *clusterd.Context, clusterInfo *client.C
func cephCrashCollectorKeyringCaps() []string {
return []string{
"mon", "allow profile crash",
"mgr", "allow profile crash",
"mgr", "allow rw",
}
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/operator/ceph/cluster/nodedaemon/keyring_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ import (

func TestCephCrashCollectorKeyringCaps(t *testing.T) {
caps := cephCrashCollectorKeyringCaps()
assert.Equal(t, caps, []string{"mon", "allow profile crash", "mgr", "allow profile crash"})
assert.Equal(t, caps, []string{"mon", "allow profile crash", "mgr", "allow rw"})
}

0 comments on commit ffaf4a1

Please sign in to comment.