Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update schema builder add/set actions to have unique errors #4386

Conversation

guilhermecastros
Copy link
Contributor

@guilhermecastros guilhermecastros commented Nov 18, 2024

Reasons for making this change

I believe adding the same error to the list does not provide additional value.

  • Updated schema builder errors list to only contain unique errors
    • addErrors & setErrors were updated

Example

Before
image

After
image

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

@guilhermecastros Thanks for the fix, can you update the CHANGELOG.md as well?

@guilhermecastros
Copy link
Contributor Author

@heath-freenome Just added to the CHANGELOG.md :)

@heath-freenome heath-freenome merged commit 306f2b3 into rjsf-team:main Nov 22, 2024
5 checks passed
@guilhermecastros guilhermecastros deleted the error-schema-builder-add-set-unique-errors branch November 23, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants