Fix: made small changes to utility functions to fix #3997, #4314 and #4322 #4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please merge this pr fast |
I am having to deal with a regression that was detected in testing and my job is quite busy. Working as fast as I can, sorry |
heath-freenome
force-pushed
the
fix-3997-and-4322
branch
from
5db135a
to
d06c44c
Compare
heath-freenome
changed the title
|
Ok, in order to avoid regressions, I added a new, optional |
nickgros
approved these changes
Oct 20, 2024
Comment on lines
+24
to
+26
| it('should return default when formData is undefined and defaultSupercedesUndefined true', () => { | ||
| expect(mergeDefaultsWithFormData({}, undefined, undefined, true)).toEqual({}); | ||
| }); |
There was a problem hiding this comment.
May want to add a case where null is returned when formData is null
heath-freenome
force-pushed
the
fix-3997-and-4322
branch
from
cf72e03
to
0294e30
Compare
…rjsf-team#4322 Fixes rjsf-team#3997 and rjsf-team#4322 - In `@rjsf/utils`, made the following changes: - Updated `mergeDefaultsWithFormData()` to not overwrite a default when the formData has an undefined value - Updated `getClosestMatchingOption()` to improve the scoring function so that an object container that matches a key gets an extra point - In `@rjsf/core`, updated `MultiSchemaField` to call `onChange` after setting the new option in state rather than before - Updated the `CHANGELOG.md` accordingly
…ta` prop to the `Experimental_DefaultFormStateBehavior` - Updated `mergeDefaultsWithFormData()` to add new optional `defaultSupercedesUndefined` that when true uses the defaults rather than `undefined` formData - Updated `getDefaultFormState()` to pass true to `mergeDefaultsWithFormData` for `defaultSupercedesUndefined` when `mergeDefaultsIntoFormData` has the value `useDefaultIfFormDataUndefined` - Updated the documentation for the new capabilities - Updated the playground to add controls for the new `mergeDefaultsIntoFormData` option - moved the `Show Error List` component over one column, making it inline radio buttons rather than a select
heath-freenome
force-pushed
the
fix-3997-and-4322
branch
from
0294e30
to
2c9d418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #3977, #4314, #4322
@rjsf/utils, made the following changes:mergeDefaultsIntoFormDataoption toExperimental_DefaultFormStateBehaviortype to control how to handle merging of defaultsmergeDefaultsWithFormData()to add new optionaldefaultSupercedesUndefinedthat when true uses the defaults rather thanundefinedformDatagetDefaultFormState()to pass true tomergeDefaultsWithFormDatafordefaultSupercedesUndefinedwhenmergeDefaultsIntoFormDatahas the valueuseDefaultIfFormDataUndefinedgetClosestMatchingOption()to improve the scoring function so that an object container that matches a key gets an extra point@rjsf/core, updatedMultiSchemaFieldto callonChangeafter setting the new option in state rather than beforemergeDefaultsIntoFormDataoptionShow Error Listcomponent over one column, making it inline radio buttons rather than a selectCHANGELOG.mdaccordinglyChecklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.