Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: readOnly not working in 5.18.5 #4236

Closed
4 tasks done
rap1ds opened this issue Jul 2, 2024 · 5 comments · Fixed by #4238
Closed
4 tasks done

Regression: readOnly not working in 5.18.5 #4236

rap1ds opened this issue Jul 2, 2024 · 5 comments · Fixed by #4238
Assignees
@nickgros
Labels
bug

Comments

@rap1ds
Copy link

rap1ds commented Jul 2, 2024 •
edited
Loading

Prerequisites

What theme are you using?

core

Version

5.18.5

Current Behavior

Boolean fields with readOnly: true are enabled, i.e. user is able to click the checkbox

Expected Behavior

Boolean fields with readOnly: true should be disabled, i.e. user should not be able to click the checkbox

Steps To Reproduce

  1. Open this Playground example
  2. Click the "foo" checkbox

Expected: Checkbox can't be clicked

Actual: Checkbox can be clicked. The data value changes.

Environment

This seems to be regression bug.

I noticed this bug when I upgraded RJSF from 5.6.2 -> 5.18.5.

Then I did a bit more bisecting and noticed that 5.18.4 works fine.

So the issue occurs when upgrading from 5.18.4 -> 5.18.5. Maybe [this PR](https://github.com/rjsf-team/react-jsonschema-form/pull/4212)?

Anything else?

No response
@rap1ds rap1ds added bug needs triage Initial label given, to be assigned correct labels and assigned labels Jul 2, 2024
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Jul 2, 2024
@nickgros
SchemaField: Only use nullish coalescing with uiOptions when computin…
41280dc 
…g readonly

fixes rjsf-team#4236
nickgros added a commit to nickgros/react-jsonschema-form that referenced this issue Jul 2, 2024
@nickgros
SchemaField: Only use nullish coalescing with uiOptions when computin…
066b1ed 
…g readonly

fixes rjsf-team#4236
@nickgros nickgros mentioned this issue Jul 2, 2024
Merged
8 tasks
@nickgros nickgros self-assigned this Jul 2, 2024
@nickgros nickgros removed the needs triage Initial label given, to be assigned correct labels and assigned label Jul 2, 2024
@rap1ds
Copy link
Author

rap1ds commented Jul 3, 2024

That was a fast fix! Thank you! 🙏🍬

@rap1ds
Copy link
Author

rap1ds commented Jul 3, 2024

It looks like this issue isn't fixed in 5.18.6, even though the CHANGELOG says it should be fixed in that version.

I upgraded from 5.18.4 -> 5.18.6 and noticed that the regression bug was still there.

I checked from NPM the code of SchemaField.tsx of the newest 5.18.6 version and saw that it did not contain the fix. Maybe there was an error in the NPM release?

@nickgros
Copy link
Contributor

nickgros commented Jul 3, 2024

Sorry about that @rap1ds ... it looks like the tag was applied to the wrong commit: https://github.com/rjsf-team/react-jsonschema-form/blob/v5.18.6/packages/core/src/components/fields/SchemaField.tsx

@heath-freenome Let's push another release (either 5.18.7 or 5.19.0) soon so we can properly publish this fix

@heath-freenome
Copy link
Member

@rap1ds @nickgros I'm pushing a fix that will go into 5.19.0 momentarily. I'll cut the release by the end of today

@rap1ds
Copy link
Author

rap1ds commented Jul 3, 2024

No worries! Thanks for a fast fix!

miguelgrc added a commit to miguelgrc/react-formule that referenced this issue Jul 15, 2024
@miguelgrc
build(deps): bump rjsf to v5.19.0 to fix readonly fields
97699aa 
v15.18.x introduced a bug that made readonly fields not work
rjsf-team/react-jsonschema-form#4236
@miguelgrc miguelgrc mentioned this issue Jul 15, 2024
Merged
pamfilos pushed a commit to cern-sis/react-formule that referenced this issue Aug 8, 2024
@miguelgrc @pamfilos
build(deps): bump rjsf to v5.19.0 to fix readonly fields
3444992 
v15.18.x introduced a bug that made readonly fields not work
rjsf-team/react-jsonschema-form#4236
nickgros added a commit that referenced this issue Aug 18, 2024
@nickgros
Merge changes in main to rjsf-v6 (#4276)
94b54dc 
Co-authored-by: Heath C <[email protected]>
Co-authored-by: Abdallah Al-Soqatri <[email protected]>
Co-authored-by: Kevin Burnett <[email protected]>
Co-authored-by: Marek Bodinger <[email protected]>
Co-authored-by: Mehdi Salem <[email protected]>
Co-authored-by: Nick Grosenbacher <[email protected]>
Co-authored-by: Abdallah Al-Soqatri <[email protected]>
Co-authored-by: Jonasz Wiącek <[email protected]>
Co-authored-by: Bogdan Savluk <[email protected]>
Co-authored-by: Christian Wendt <[email protected]>
Co-authored-by: Ben Lambert <[email protected]>
Co-authored-by: David R. Bild <[email protected]>
Co-authored-by: Ariqun <[email protected]>
Co-authored-by: Shivam Anand Murmu <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shubham Biswas <[email protected]>
Co-authored-by: popmanhe <[email protected]>
Co-authored-by: Yuki Aoki <[email protected]>
Co-authored-by: Xiangcheng Kuo <[email protected]>
Co-authored-by: Bart van Andel <[email protected]>
Co-authored-by: Laurent Direr <[email protected]>
Co-authored-by: Vegard Stenvik <[email protected]>
Co-authored-by: Appie <[email protected]>
Co-authored-by: Oren Forer <[email protected]>
Co-authored-by: Marcus Penn <[email protected]>
Co-authored-by: joachimhagheim <[email protected]>
Co-authored-by: MarekBodingerBA <[email protected]>
Co-authored-by: momesana <[email protected]>
Co-authored-by: Martti Roitto <[email protected]>
Co-authored-by: Serge van den Oever <[email protected]>
Co-authored-by: Enzo Ferey <[email protected]>
Co-authored-by: Skyf0l <[email protected]>
Co-authored-by: Jaejoon Han <[email protected]>
Co-authored-by: とまとみ <[email protected]>
Co-authored-by: Daniel Todd <[email protected]>
Co-authored-by: Dmitry Dzhus <[email protected]>
Co-authored-by: Alexander Kachkaev <[email protected]>
Co-authored-by: shaddollxz <[email protected]>
Co-authored-by: Changyu Geng <[email protected]>
Co-authored-by: Helen Lin <[email protected]>
Co-authored-by: solimant <[email protected]>
Co-authored-by: David Li <[email protected]>
fix(utils): direct lodash function import to improve bundling on library client side (#3976)
fix: #3961 resolve all recurse list for object properties (#3981)
fix gap in outline when label is hidden (#3984)
Fix: Expose the internal `ajv` variable in the validator implementation classes (#3991)
Fixes: #3972 indirectly by exposing the `ajv` variable for use in the issue
Fix: Change FormHelperText usage with @mui/material to render divs (#4032)
Fixes #4031 by switching the render component for `FormHelperText` to be `div`
fix: Added support for anyOf/oneOf in uiSchema (#4055)
Fixes #4039 by updating `MultiSchemaField` to properly support `anyOf`/`oneOf` arrays in the `uiSchema`
Fix checkbox with 0 as a value was unselectable in antd (#4068)
Fixed #4067 by properly dealing with enums that have 0 as a value
Fix potential XSS in the preview button of FileWidget (#4065)
Fix: Make 'ui:rows' option work with chakra-ui for textarea elements #4070 (#4078)
Fix typo in ErrorsListTemplate example (#4087)
Fix #4080 by moving `base64` encoder/decoder from `@rjsf/utils` to playground (#4093)
Fix: Error state not resetting when schema changes (#4079) (#4103)
Fix noImplicitAny error (#4106)
Fixes: [WARNING] Duplicate key "include" in object literal [duplicate-object-key] (#4114)
Fixes: Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>. (#4117)
Fix documentation to add missing Form imports (#4131)
Fix #4127 to add missing `Form` import in documentation
Fix: filename should be bold (#4125)
Fix: use correct ConfigProvider context by using named imports (#4132)
Fix 4134 by filtering out bad DOM props (#4140)
Fixes: #4134 by updating the spreading of props onto the `TextField` to remove bad DOM fields
Fixed Programmatic submit not working properly in Firefox (#4150)
Fix Maximum call stack size exceeded in findSchemaDefinition (#4123)
fix typos in constants.ts, Form.tsx (#4185)
Fix mui imports in docs (#4218)
fix] Resetting number fields should check the entire string when deciding to leave the input text alone (#4202) (#4220)
Fixed performance issue with large schema dependencies and oneOf (#4203) (#4204)
Fixed performance issue #4203
fix(core): field ui-options higher priority (#4212)
fix(antd): disabled property of options of antd theme (#4216)
fix: omitExtraData on submit and on validateForm (#4228)
Fix IdSchema and PathSchema types (#4196)
fixes #4236
Fix #4197 in various themes by showing empty option in SelectWidget when appropriate (#4200)
fix: xss when rendering schema errors (#4256)
fix 4215 and 4260 by updating optionsList() to take a uiSchema (#4263)
Fixes #4215 and #4260 by supporting alternate titles for enums and anyOf/oneOf lists via the uiSchema
Fixed Changelog (#4269)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickgros nickgros

Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@rap1ds @nickgros @heath-freenome