Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix local setup, readOnly fields and cypress tests #64

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

miguelgrc
Copy link
Collaborator

@miguelgrc miguelgrc commented Jul 2, 2024

  • The local setup (simple way) was not working without yarn linking react and react-dom. Now, by adding a dedupe statement for those two dependencies, it works out of the box without the need to use yarn link. Note that for the advanced way (i.e. linking the bundle) yarn link is still needed as mentioned in formule-demo's readme. Some legacy yarn commands have been removed as well.
  • Cypress tests were failing:
    • readOnly fields were not working anymore after a bug was introduced in rjsf v5.18.x (Regression: readOnly not working in 5.18.5 rjsf-team/react-jsonschema-form#4236), it has been solved in v5.19.0 so the version has been bumped.
    • Selectors were failing since we had changed the rjsf separator from the default _ to $. I have found ! to be more convenient and easier to adapt the tests to work again with so I have changed it. I have also updated the tests accordingly and overwritten the get and find cypress methods to escape the ! character so that we don't have to do it manually (\\!) every time.
    • Cypress has been bumped to the latest version, which has also corrected an issue that made us unable to use moduleResolution: bundler in formule-demo (Unable to compile TypeScript with "moduleResolution": "bundler" option in v5 cypress-io/cypress#27731). Some compiler settings have been updated accordingly.

Also closes #61

@miguelgrc miguelgrc force-pushed the fix-local-setup-dedupe branch 3 times, most recently from 29c92c1 to 58439b2 Compare July 2, 2024 14:29
@miguelgrc miguelgrc changed the title build(local): add dedupe deps to fix aliased local setup fix local setup, readOnly fields and cypress tests Jul 15, 2024
@pamfilos pamfilos merged commit 8bc84b0 into cern-sis:master Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

form: make RJSF id separator to be customizable for each form
2 participants