-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecal libs #34
Open
somovalex
wants to merge
165
commits into
rjones30:master
Choose a base branch
from
JeffersonLab:ecal_libs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ecal libs #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wires in the fdc. [rtj]
…_fix_rtj This fixes the discrepancy between G3/G4 as shown in issue #181
for their location. Note these are still hard coded and will need a proper treatement using ccdb in the near future.
constants, and convert to internal units. [rtj]
make FMWPC wire locations compatible with using cm as units
…tively move division by wire_pitch inside the floor function.
change wire pitch and wire offsets to 1.016*cm and 73*1.016*cm respec…
since normally the user starts off without one, and this message is really only a warning anyway. [rtj]
type for the converter material. [rtj]
production in the liquid hydrogen target when GENBEAM 'BHgen' is set in control.in [rtj]
in the tracking inside sweeping magnets in the photon beamline [rtj]
volume type is correctly reported as kParameterised when the division is added as a daughter to divide a mother volume. [rtj]
add more detail to error messages [rtj]
generation mechanism, based on the G4BetheHeitler5DModel class introduced in G4.10.06, modeled after G4BeamConversionProcess [rtj]
generic G4VDiscreteProcess to the more specific G4VEmProcess; [rtj] * add new c++ class member modifiers (virtual, explicit, override, final) to better document their purpose and role; [rtj] * introduce InitialiseProcess members to take care of initialization of internal tables for the generators, rather than waiting to do all initialization at tracking time; [rtj] * remove the copy constructor; [rtj] * set verboseLevel=0 in the constructor to reduce unnecessary verbage at startup time; [rtj]
and GlueXBernardConversionProcess side-by-side in the same executable. [rtj] * protect GlueXPhysicsList.cc against compiling without the G4BetheHeitler5DModel header file available. [rtj] * include the G4PairConversionRelModel.hh header in case we are building GlueXBeamConversionProcess without the more powerful G4BetheHeitler5DModel class available (G4.10.04 and earlier) [rtj]
prior to G4.10.04 [rtj]
sections for Bethe Heitler processes. [rtj]
of hydrogen. [rtj]
in step size in the stepTrial loop, when the loop approaches the maxTrial count without having achieved convergence. This corrects a fatal error in the tracking that occurred for low-momentum e- tracks curling in the non-homogeneous field at the downstrea end of the FDC, that would reach the end of the stepTrial loop before the step size gets small enough to achieve the expected accuracy. * include unmodified copies of the standard G4ChordFinderDelegate.hh, G4IntegrationDriver.hh, G4MagIntegratorDriver.hh where the template G4ChordFinderDelegate is instantiated. [rtj] * include G4ChordFinder.cc to trigger the inclusion of the updated template code in the G4ChordFinderDelegate.icc source file.
work with either zero polarization or unit (full linear) polarization of incoming photons in the pair conversion process. [rtj]
in the GlueX target on a similar basis as e+e- pair conversion that happens when GENBEAM 'BHgen' is set in control.in [rtj] * generalize PairConversionProcess to allow for any lepton pair to be created by gamma conversion from a nuclear or free electron target. [rtj]
the GlueXBernardConversionProcess to switch from e+e- to mu+mu- pair conversion, based on the first GENBEAM argument being 'BHgen' for e+e- or 'BHmuons' for mu+mu-. [rtj] * add a support to GlueXBeamConversionProcess to control the switching between e+e- and mu+mu- pair conversion at startup. [rtj]
Bethe Heitler pair production by high energy electron beam. [rtj]
without modification, because they are in the dependency list of this one class G4VDivisionParameterisation that I needed to split to make it thread-safe. [rtj]
source tree into G4.10.07.p03fixes to make sure that all instances of #include "G4VDivisionParameterisation.hh" pick up the modified version of that file. [rtj]
has assigned as the new pdg particle number for optical (Cerenkov) photons. [rtj]
ownership of the newly constructed G4Rotation object seems to be being passed to the host G4VPhysicalVolume object at the end of this method. [rtj]
gammas and optical photons, whereas starting at 10.7 the code for optical photons changes to -22. Suppress warnings about unknown particle code -22 for older library binaries. [rtj]
propagated to all tracking threads. [rtj]
tracking is turned on [rtj]
where it resets the internal state of G4MagHelicalStepper objects at the start of each new event, otherwise repeatability is lost when running multi-threaded. [rtj]
decay secondaries in the vertex record, not other secondaries that were generated along with the decays in the final tracking step. [rtj]
replace leading tabs with spaces. [rtj]
and writing them out ordered by eventNo, optionally erasing the hitView secondary vertex information for repeat simulations. [rtj]
…oduces long tail not observed in data. follow example from ST
Leading edge time for TOF, CTOF, PS and PSC
* are calculated [rtj]
don't you want to make this PR to https://github.com/JeffersonLab/HDGeant4 instead? |
a primary track from the input hddm file and assign it to the G4PrimaryTrack object; fixes to GlueXBeamConversionProcess to avoid division by zero in the case of an unpolarized beam photon, or a target nucleus at rest in the lab. [rtj]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial ECAL libs