Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for assembling slti instructions. #4508

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

matteius
Copy link
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

I extended my local version of cutter to be able to insert multiple MIPs instructions at once, then I realized it can dissasemble slti isntructions but not re-assemble them so I was getting errors inserting these.

Test plan

Just trying to help, but before this change this would fail:

(base) matteius@matteius-3-0:~/cutter/build$ ./Rizin-prefix/bin/rz-asm -a mips -b 32 'slti v0, a0, 9'
09008228

Closing issues
Not sure if this has been reported in any issues yet.

@wargio
Copy link
Member

wargio commented May 23, 2024

please add a test under the tests/db/asm dir

@matteius
Copy link
Contributor Author

@wargio Are the asm tests there just testing that it can compute the assembly of an instruction using in this case slti? Also I don't see a regular mips32 or mips test file, but I do see mips64 ...

@wargio
Copy link
Member

wargio commented May 23, 2024

you are right. that is indeed an issue. ok for me then.

@wargio
Copy link
Member

wargio commented May 23, 2024

#4509

@wargio wargio merged commit 1d9ae2a into rizinorg:dev May 23, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants