ci macos-x86_64: Upgrade to the macos-13 image #3387
Conversation
|
Redness is unrelated |
kazarmy
changed the title
I agree 78a9998 |
|
As for the hdiutil failures I guess it's worth trying the second workaround described here. |
|
Ok 29931e7 |
|
That's separate problem, but the M1 macos failure can be fixed by adding |
There's no guarantee that the first Python version found won't be 3.13. Btw, the |
I would hope that having explicit "Python_ROOT_DIR" hint has higher priority in the search order compared to whatever default search folders are. |
kazarmy
force-pushed
the
macos-14-large
branch
from
db06aa7
to
e78c29c
Compare
|
WTF. why |
|
@kazarmy i merged my fix on jsdec repo (with also a test for msvc 2019) |
.github/workflows/ci.yml
Outdated
| # https://github.com/actions/runner-images/issues/7522#issuecomment-1556766641 | ||
| echo killing XProtectBehaviorService; sudo pkill -9 XProtect >/dev/null || true; | ||
| echo waiting for XProtectBehaviorService kill; while pgrep XProtect; do sleep 3; done; | ||
| brew install kadwanev/brew/retry |
There was a problem hiding this comment.
maybe move this eariler since you are installing a dependency.
| echo killing XProtectBehaviorService; sudo pkill -9 XProtect >/dev/null || true; | ||
| echo waiting for XProtectBehaviorService kill; while pgrep XProtect; do sleep 3; done; | ||
| brew install kadwanev/brew/retry | ||
| retry 'rm -rf ../jsdec ../libswift ../rz_libyara ../rz-silhouette; make package' |
There was a problem hiding this comment.
why this is done on some plugins and not all the plugins? is this related to some redness where they do not compile? if yes, add a comment explaining why this is here.
There was a problem hiding this comment.
it's due to (https://github.com/rizinorg/cutter/actions/runs/11425970615/job/31788307472#step:7:9706):
the other plugins were rimrafed because the build is so slow and it would have taken too long to check the plugins one-by-one
There was a problem hiding this comment.
if yes, add a comment explaining why this is here.
ok 97b93a5
Your checklist for this pull request
Detailed description
The GitHub macos-12 image is in the process of being removed so this pr replaces it with the macos-13 image.
Test plan (required)
The replacement is appropriate.
Closing issues
...