Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added patch for filter option in electron-unhandled #268

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

vinodf2f
Copy link
Contributor

@vinodf2f vinodf2f commented Feb 9, 2021

No description provided.

@vercel
Copy link

vercel bot commented Feb 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ritz078/moose/231c6i9y5
✅ Preview: https://moose-git-fork-vinodf2f-feat-errorfilteroption.ritz078.now.sh

Comment on lines +63 to +79
declare const unhandled: {
/**
Catch unhandled errors and promise rejections in your [Electron](https://electronjs.org) app.
-
You probably want to call this both in the main process and any renderer processes to catch all possible errors.
*/
(options?: unhandled.UnhandledOptions): void;

/**
Log an error. This does the same as with caught unhandled errors.
-
It will use the same options specified in the `unhandled()` call or the defaults.
-
@param error - Error to log.
*/
logError(error: Error, options?: unhandled.LogErrorOptions): void;
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these added here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added typescript type for filter in index.t.ds

@ritz078
Copy link
Owner

ritz078 commented Feb 12, 2021

@vinodf2f Can you fix #74 in this one too ? You will have to pass that error in filter option.

Copy link
Owner

@ritz078 ritz078 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Make sure you undo this change when your original PR on electron-unhandled is merged.

@ritz078 ritz078 merged commit b2fc281 into ritz078:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants