Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ledger lines to accid not child of note #3857

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Add ledger lines to accid not child of note #3857

merged 4 commits into from
Nov 11, 2024

Conversation

lpugin
Copy link
Contributor

@lpugin lpugin commented Nov 11, 2024

@kepper please double check

image 
<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="https://music-encoding.org/schema/4.0.0/mei-all.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
<?xml-model href="https://music-encoding.org/schema/4.0.0/mei-all.rng" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
<mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="4.0.0">
    <meiHead>
        <fileDesc>
            <titleStmt>
                <title>Pickup note spacing</title>
            </titleStmt>
            <pubStmt>
                <date isodate="2017-07-28">2017-07-28</date>
            </pubStmt>
            <seriesStmt>
                <title>Verovio test suite</title>
            </seriesStmt>
            <notesStmt>
                <annot>Verovio appropriately spaces pickup notes.</annot>
            </notesStmt>
        </fileDesc>
        <encodingDesc>
            <appInfo>
                <application version="2.0.0" label="2">
                    <name>Verovio</name>
                </application>
            </appInfo>
        </encodingDesc>
    </meiHead>
    <music>
        <body>
            <mdiv>
                <score>
                    <scoreDef midi.bpm="400">
                        <staffGrp>
                            <staffDef n="1" lines="5" clef.shape="G" clef.line="2" />
                        </staffGrp>
                    </scoreDef>
                    <section>
                        <measure>
                            <staff n="1">
                                <layer n="1">
                                    <accid accid="f" loc="10"></accid>
                                    <note loc="10" dur="4"></note>
                                    <accid accid="x" loc="10"></accid>
                                    <note loc="10" dur="4"></note>
                                    <accid accid="ff" loc="11"></accid>
                                    <note loc="11" dur="4"></note>
                                    <accid accid="tf" loc="12"></accid>
                                    <note loc="12" dur="4"></note>
                                </layer>
                            </staff>
                        </measure>
                        <measure>
                            <staff n="1">
                                <layer n="1">
                                    <accid accid="f" loc="-1"></accid>
                                    <note loc="-1" dur="4"></note>
                                    <accid accid="x" loc="-2"></accid>
                                    <note loc="-2" dur="4"></note>
                                    <accid accid="ff" loc="-3"></accid>
                                    <note loc="-3" dur="4"></note>
                                    <accid accid="tf" loc="-4"></accid>
                                    <note loc="-4" dur="4"></note>
                                </layer>
                            </staff>
                        </measure>
                    </section>
                </score>
            </mdiv>
        </body>
    </music>
</mei>

@kepper
Copy link
Contributor

kepper commented Nov 11, 2024

looks good so far – many thanks!

@lpugin lpugin merged commit 911d63c into develop Nov 11, 2024
9 checks passed
@lpugin lpugin deleted the develop-ledger-lines branch November 11, 2024 13:43
@lpugin lpugin mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpugin @kepper