-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): optionally limit kafka input throughput bytes #7058
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7058 +/- ##
==========================================
- Coverage 73.33% 73.32% -0.01%
==========================================
Files 1045 1045
Lines 167653 167659 +6
==========================================
- Hits 122940 122929 -11
- Misses 44713 44730 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
With limiting source throughput:
Without:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
It can work as a temp fix for fine-tuning the performance but not a user-facing option. |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add a configurable parameter to limit the source throughput in terms of bytes.
This parameter may or may not(so not go into doc and release notes this time) be intended to be used by public users at the moment.
It is convenient for people to test resource utilization/performance for a fixed input throughput.(https://redpanda.com/blog/redpanda-vs-kafka-performance-benchmark#:~:text=3.2%20under%20workloads%20(-,up%20to%201GB/sec,-)%20that%20are%20common)
Otherwise, people have to always generate events by some source generators on the fly to Kafka/Redpanda at exactly the throughput you want, which may not be achievable and depends on many other factors.
Instead, we can pre-generate a lot and then limit the source throughput stably.
Also, it may be a workaround solution for #5214.
Checklist
I have added necessary unit tests and integration tests./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)