-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): more meta backend agnostic e2e tests in main-cron
#19595
Open
BugenZhao
wants to merge
6
commits into
main
Choose a base branch
from
bz/main-cron-more-sql-backend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
BugenZhao
changed the title
feat(ci): more meta backend agnostic e2e tests in
feat(ci): more meta backend agnostic e2e tests in Nov 27, 2024
main-cron
main-cron
[WIP]
BugenZhao
force-pushed
the
bz/ci-adopt-env-sql-backend
branch
from
November 28, 2024 05:18
1299e28
to
6f02e68
Compare
BugenZhao
force-pushed
the
bz/main-cron-more-sql-backend
branch
from
November 28, 2024 05:18
c4ebaab
to
1ef154b
Compare
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/main-cron-more-sql-backend
branch
from
November 28, 2024 07:13
e8243da
to
3ebce58
Compare
BugenZhao
changed the title
feat(ci): more meta backend agnostic e2e tests in
feat(ci): more meta backend agnostic e2e tests in Nov 29, 2024
main-cron
[WIP]main-cron
kwannoel
approved these changes
Dec 2, 2024
Seems like |
xxchan
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Use
meta-backend: env
for all CI RiseDev profiles.meta-backend: sqlite
is specified, ensuring compatibility with the behavior prior to this PR.Extend coverage for PG/MySQL meta backends on
main-cron
toNote that although there are many other steps for specific connectors, I suppose it may not be necessary to cover them all, as the execution path on the meta node should not differ significantly.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.