Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): more meta backend agnostic e2e tests in main-cron #19595

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Nov 27, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Use meta-backend: env for all CI RiseDev profiles.

    • use a persisted SQLite database as a fallback when env var is not set, behaving as if meta-backend: sqlite is specified, ensuring compatibility with the behavior prior to this PR.
  • Extend coverage for PG/MySQL meta backends on main-cron to

    • slow e2e test
    • parallel e2e test
    • e2e source test
    • e2e sink test

Note that although there are many other steps for specific connectors, I suppose it may not be necessary to cover them all, as the execution path on the meta node should not differ significantly.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

BugenZhao commented Nov 27, 2024

@BugenZhao BugenZhao changed the title feat(ci): more meta backend agnostic e2e tests in main-cron feat(ci): more meta backend agnostic e2e tests in main-cron [WIP] Nov 27, 2024
Base automatically changed from bz/ci-adopt-env-sql-backend to main November 28, 2024 05:56
@graphite-app graphite-app bot requested a review from a team November 28, 2024 07:51
@BugenZhao BugenZhao changed the title feat(ci): more meta backend agnostic e2e tests in main-cron [WIP] feat(ci): more meta backend agnostic e2e tests in main-cron Nov 29, 2024
@kwannoel
Copy link
Contributor

kwannoel commented Dec 2, 2024

Seems like main-cron tests still fail. Let's make it pass before merging. Or disable the failing tests first.

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@xxchan
Copy link
Member

xxchan commented Dec 2, 2024

failure looks strange

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants